Re: [PATCH davem] drivers: add LCD support

[Miguel Ojeda]

On 12/18/06, Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
> Hi,
>
> Shouldn't the framebuffer part of this code (cfag12864bfb) also
> depend on CONFIG_FB?  Without that, this build error occurs:

Indeed it should. Thanks for noticing that!

> cfag12864bfb.c:(.init.text+0xc19d): undefined reference to `framebuffer_alloc'
> cfag12864bfb.c:(.init.text+0xc211): undefined reference to `register_framebuffer'
> cfag12864bfb.c:(.text+0xf2782): undefined reference to `unregister_framebuffer'
> cfag12864bfb.c:(.text+0xf2789): undefined reference to `framebuffer_release'
>
> (from 2.6.20-rc1-mm1)
>
> so you may need to modify the Kconfig and Makefile to have a
> separate config entry for cfag12864bfb (or is it always required?).

For normal users, yes, it is the only way (yet) to use cfag12864b
(through a framebuffer). However, I divided the code in logical blocks
so it is more modular (easier understanding, scalability...), so
anyone can easily add a new way to control the LCD without worring
about other unrelated stuff the code.

> And while you are there (in the Kconfig file), please change
> (hertzs) to (hertz).

Thanks again.

--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/