Re: [PATCH] netpoll: make arp replies through netpoll use macaddress of sender

From: David Miller
Date: Fri Dec 08 2006 - 03:07:25 EST


From: Neil Horman <nhorman@xxxxxxxxxxxxx>
Date: Thu, 7 Dec 2006 14:45:53 -0500

> Back in 2.4 arp requests that were recevied by netpoll were processed in
> netconsole_receive_skb, where they were responded to using the src mac of the
> request sender. In the 2.6 kernel arp_reply is responsible for this function,
> but instead of using the src mac address of the incomming request, the stored
> mac address that was registered for the netconsole application is used. While
> this is usually ok, it can lead to failures in netpoll in some situations
> (specifically situations where a network may have two gateways, as arp requests
> from one may be responded to using the mac address of the other). This patch
> reverts the behavior to what we had in 2.4, in which all arp requests are sent
> back using the src address of the request sender.
>
> Signed-off-by: Neil Horman <nhorman@xxxxxxxxxxxxx>

Applied, and I'll push this to -stable, thanks Neil.

But please submit networking patches next time to
netdev@xxxxxxxxxxxxxxx, most of the networking developers did not see
this patch because you sent it to the user help list (linux-net)
instead of the developer list (netdev).

Thanks again.
-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html