Re: [PATCH 2/2] eCryptfs: Public key; packet management

[Andrew Morton]

On Wed, 6 Dec 2006 17:12:37 -0600
Michael Halcrow <mhalcrow@xxxxxxxxxx> wrote:

> Public key support code. This reads and writes packets in the header
> that contain public key encrypted file keys. It calls the messaging
> code in the previous patch to send and receive encryption and
> decryption request packets from the userspace daemon.
> 
> ...
>
> +		memset(auth_tok_list_item, 0,
> +		       sizeof(struct ecryptfs_auth_tok_list_item));
> +		kmem_cache_free(ecryptfs_auth_tok_list_item_cache,
> +				auth_tok_list_item);
>
> ...
>
> +	memset(auth_tok_list_item, 0,
> +	       sizeof(struct ecryptfs_auth_tok_list_item));
> +	kmem_cache_free(ecryptfs_auth_tok_list_item_cache,
> +			auth_tok_list_item);

That's a bit wasteful of cycles.  Or is this done to minimise the exposure
of sensitive data?  If so, a comment would be in order.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/