Re: -mm merge plans for 2.6.20

From: Andrew Morton
Date: Tue Dec 05 2006 - 14:43:39 EST


On Tue, 5 Dec 2006 18:25:58 +0000 (GMT)
James Simmons <jsimmons@xxxxxxxxxxxxx> wrote:

> > > > video-sysfs-support-take-2-add-dev-argument-for-backlight_device_register.patch
> > >
> > > Does this patch update the fbdev drivers?
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19-rc6/2.6.19-rc6-mm2/broken-out/video-sysfs-support-take-2-add-dev-argument-for-backlight_device_register.patch
> >
> > Seems not. Should it?
>
> Yes. Its bizarre.

It is.

> The drivers compile with the wrong method prototype.

No, it doesn't get compiled at all.

CONFIG_FB_ATY128_BACKLIGHT has no Kconfig record at all.

CONFIG_FB_NVIDIA_BACKLIGHT has no Kconfig record at all.

CONFIG_FB_RIVA_BACKLIGHT has no Kconfig record at all.

So this is all dead code. There is no way to enable any of it within the
config system.

> I
> updated the fbdev drivers to the new backlight_device_register and it
> compiled as expect. There are a few other problems with teh fbdev drivers.
> I will send a patch.

It's a start ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/