Re: [-mm patch] sched remove lb_stopbalance counter

From: Ingo Molnar
Date: Tue Dec 05 2006 - 10:34:02 EST



* Chen, Kenneth W <kenneth.w.chen@xxxxxxxxx> wrote:

> in -mm tree: I would like to revert the change on adding
> lb_stopbalance counter. This count can be calculated by: lb_balanced
> - lb_nobusyg - lb_nobusyq. There is no need to create gazillion
> counters while we can derive the value. I'm more of against changing
> sched-stat format unless it is absolutely necessary as all user land
> tool parsing /proc/schedstat needs to be updated and it's a real pain
> trying to keep multiple versions of it.
>
> Signed-off-by: Ken Chen <kenneth.w.chen@xxxxxxxxx>

Acked-by: Ingo Molnar <mingo@xxxxxxx>

but, please:

> -#define SCHEDSTAT_VERSION 13
> +#define SCHEDSTAT_VERSION 12

change this to 14 instead. Versions should only go upwards, even if we
revert to an earlier output format.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/