Re: [RFC][PATCH 2/2] x86_64: earlyprintk usb debug device support.

From: Greg KH
Date: Mon Dec 04 2006 - 15:33:55 EST


On Mon, Dec 04, 2006 at 12:18:30PM -0800, Lu, Yinghai wrote:
> -----Original Message-----
> From: ebiederm@xxxxxxxxxxxx [mailto:ebiederm@xxxxxxxxxxxx]
>
> >arch/x86_64/kernel/early_printk.c | 574
> +++++++++++++++++++++++++++++++++++++
> > drivers/usb/host/ehci.h | 8 +
> > include/asm-x86_64/fixmap.h | 1
>
> Can you separate usbdebug handle out from early_printk?

Yeah, at least tear it out of x86-64, so those of us stuck on different
platforms can use this :)

Other than that minor issue, this looks great. I don't have a x86-64
box set up here at the moment, so I can't test it, but it looks
acceptable at first glance.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/