Re: [PATCH] 2.6.18-rt7: fix more issues with 32-bit cycles_t in latency_trace.c (take 3)

From: Ingo Molnar
Date: Mon Dec 04 2006 - 11:24:30 EST




* Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> wrote:

> > /* check for buggy clocks, handling wrap for 32-bit clocks */
> >- if (TYPE_EQUAL(cycles_t, unsigned long)) {
> >+ if (TYPE_EQUAL(cycle_t, unsigned long)) {
> > if (time_after((unsigned long)T1, (unsigned long)T2))
> > printk("bug: %08lx < %08lx!\n",
> > (unsigned long)T2, (unsigned long)T1);
>
> This earlier fix by Kevin woulnd't have sense anymore with cycle_t...

yeah, indeed - i've zapped this one too.

basically, what i'd like is the 32-bit clocks/cycles be handled
intelligently, and not adding to the cruft that already is in
kernel/latency_tracing.c.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/