RE: [PATCH 1/2] sata_nv & ahci: Move some IDs from sata_nv.c to ahci.c

[Peer Chen]

Resend the patch.
The content of memory map io of BAR5 have been change from MCP65 then sata_nv can't work fine on the platform based on MCP65 and MCP67,so move their IDs from sata_nv.c to ahci.c.
Please check attachment for new patch,thanks.

Signed-off-by: Peer Chen <pchen@xxxxxxxxxx>


-----Original Message-----
From: Jeff Garzik [mailto:jgarzik@xxxxxxxxx] 
Sent: Thursday, November 30, 2006 6:43 PM
To: Peer Chen
Cc: linux-ide@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Andrew Morton
Subject: Re: [PATCH 1/2] sata_nv & ahci: Move some IDs from sata_nv.c to ahci.c

Peer Chen wrote:
> Move the device IDs of MCP65/MCP67 from sata_nv.c to ahci.c.
> The patch will be applied to kernel 2.6.19.
> Please check attachment for the patch.
> 
> Signed-off-by: Peer Chen <pchen@xxxxxxxxxx>

Please update as follows:

1) Provide a detailed explanation as to /why/ this is needed.  I certainly encourage use of ahci over legacy mode, but the patch description tells us nothing.

2) Combine the two patches into one.  Think of a patch as an atomic operation.  If you apply your patches as submitted, then a 'git bisect' 
may reach a state where the PCI IDs exist in _neither_ sata_nv or ahci. 
  Any time you /move/ code or data, it should be in the same patch.

3) Your patches are completely unreviewable in a standard Internet mailer, because they were sent with your email base64-encoded.  For many mailers, base64 encoding means the patch is not shown nor able to be commented upon.  Indeed, some mailers make it difficult to response -at
all- to data contained in a MIME attachment.

The change itself seems OK, once suitable justification is provided.

	Jeff



-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

Attachment: patch.sata_nv-ahci
Description: patch.sata_nv-ahci