Re: [PATCH 2.6.19] kobject: kobject_uevent() returns manageable value

[Mauricio Lin]

Hi Andrew,

On 12/1/06, Andrew Morton <akpm@xxxxxxxx> wrote:
> On Thu, 30 Nov 2006 16:58:47 -0400
> Mauricio Lin <mauricio.lin@xxxxxxxxxxx> wrote:
>
> > Since kobject_uevent() function does not return an integer value to
> > indicate if its operation was completed with success or not, it is
> > worth changing it in order to report a proper status (success or
> > error) instead of returning void.
> >
> > Keep kobject_uevent() returning the status as integer provide a easier
> > way for detecting possible failure in the function. Using void
> > returning style may take people to waste more time to figure out if
> > the "send to" or "receive from" an event is a bug in the kernel or
> > user space. Furthermore, the current way to detect where the error is
> > taking place in the kobject_uevent() requires additional inclusion of
> > printk() in each "if" condition that can lead to failure.
>
> Admirable idea, but we have large changes pending against that code
> and none of this patch applies.

I have used the kobject_uevent() to send event to user space, but when
the event does not happen I have to figure out if this problem is
related to kernel or user space code. After mentioning this issue with
Greg KH, he recommended to provide a patch to fix it.

> A patch against Greg's driver tree, or against latest -mm would suit, thanks.

OK. That's good. Thanks.

BR,

Mauricio Lin.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/