Re: [PATCH] avr32: Fixup kprobes preemption handling.

From: Haavard Skinnemoen
Date: Fri Dec 01 2006 - 08:00:34 EST


On Fri, 1 Dec 2006 16:50:50 +0900
Paul Mundt <lethal@xxxxxxxxxxxx> wrote:

> While working on SH kprobes, I noticed that avr32 got the preemption
> handling wrong in the no probe case. The idea is that upon entry of
> kprobe_handler() preemption is disabled outright across the life of
> the kprobe, only to be re-enabled in post_kprobe_handler().
>
> However, in the event that the probe is never activated, there's never
> any chance of hitting the post probe handler, which allows for the
> current avr32 implementation to disable preemption indefinitely, as
> it's currently missing a re-enable when no probe is activated.

You're absolutely right. Thanks for the patch, I've added it to my tree.

HÃvard
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/