Re: [patch 3/3] fs: fix cont vs deadlock patches

From: OGAWA Hirofumi
Date: Thu Nov 30 2006 - 20:11:44 EST


Nick Piggin <npiggin@xxxxxxx> writes:

> I would be happy if you come up with a quick fix, I'm just trying to
> stamp out a few big bugs in mm. However I did prefer my way of moving
> all the exapand code into generic_cont_expand, out of prepare_write, and
> avoiding holding the target page locked while we're doing all the expand
> work (strictly, you might be able to get away with this, but it is
> fragile and ugly).
>
> AFAIKS, the only reason to use prepare_write is to avoid passing the
> get_block into generic_cont_expand?

IIRC, because generic_cont_expand is designed as really generic. It
can also use for non moronic filesystem.

In the case of reiserfs, it ->prepare_write might be necessary.
--
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/