Re: [PATCH -mm] x86_64 UP needs smp_call_function_single

From: Ingo Molnar
Date: Thu Nov 30 2006 - 04:24:38 EST


On Wed, 2006-11-29 at 23:54 -0800, Andrew Morton wrote:
> which is somewhat unpleasant. I added a WARN_ON(irqs_disabled()) to
> the
> out-of-line SMP version.

ok.
>
> btw, does anyone know why the SMP versions of this function use
> spin_lock_bh(&call_lock)?

that makes no sense (neither the get_cpu()/put_cpu() gymnastics) if this
is called with irqs disabled all the time.

Ingo
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/