Re: Broken commit: [NETFILTER]: ipt_REJECT: remove largelyduplicate route_reverse function

From: David Miller
Date: Tue Nov 28 2006 - 23:45:04 EST


From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 29 Nov 2006 15:38:29 +1100

> David Miller <davem@xxxxxxxxxxxxx> wrote:
> >
> > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> > index 9264139..95e86ac 100644
> > --- a/include/linux/netdevice.h
> > +++ b/include/linux/netdevice.h
> > @@ -94,7 +94,9 @@ #endif
> > #endif
> >
> > #if !defined(CONFIG_NET_IPIP) && \
> > - !defined(CONFIG_IPV6) && !defined(CONFIG_IPV6_MODULE)
> > + !defined(CONFIG_NET_IPGRE) && \
> > + !defined(CONFIG_IPV6_SIT) && \
> > + !defined(CONFIG_IPV6_TUNNEL)
> > #define MAX_HEADER LL_MAX_HEADER
> > #else
> > #define MAX_HEADER (LL_MAX_HEADER + 48)
>
> What if ipip/gre are modules?

Good catch, I'll fix that up by adding the missing CONFIG_*_MODULE
cases.

Longer term this is really messy, we should handle this some
other way.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/