Re: [patch] x86_64: fix earlyprintk=...,keep regression

From: Andi Kleen
Date: Tue Nov 28 2006 - 13:57:29 EST



>
> Or is there some reason you really _want_ "keep" to be different? If so,
> it should probably be commented on.

It's just that keep is the only option that can only be at the end, all
others can be followed by more, so it
made minor sense to use strcmp() to match the \0 too. But using strncmp
everywhere is fine too since the syntax checking on these things is always
quite weak and it probably doesn't make much difference either way.

I would have gone with Ingo's fix, but if you prefer strncmp..?

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/