Re: [PATCH -mm] sata_nv: fix ATAPI in ADMA mode

From: Jeff Garzik
Date: Mon Nov 27 2006 - 18:32:21 EST


Andrew Morton wrote:
On Sun, 26 Nov 2006 14:20:19 -0600
Robert Hancock <hancockr@xxxxxxx> wrote:

static irqreturn_t nv_adma_interrupt(int irq, void *dev_instance)
{
struct ata_host *host = dev_instance;
int i, handled = 0;
+ u32 notifier_clears[2];
spin_lock(&host->lock);
for (i = 0; i < host->n_ports; i++) {
struct ata_port *ap = host->ports[i];
+ notifier_clears[i] = 0;

Promise us that n_ports will never exceed 2?

ADMA spec is only defined for two channels, at least.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/