Re: [Patch 3/7] driver core fixes: device_register() retval check in platform.c

From: Russell King
Date: Mon Nov 27 2006 - 06:25:26 EST


On Mon, Nov 27, 2006 at 10:35:08AM +0100, Cornelia Huck wrote:
> From: Cornelia Huck <cornelia.huck@xxxxxxxxxx>
>
> Check the return value of device_register() in platform_bus_init().

I still say this is absolutely crazy. If a bus does not get registered,
what happens to all the devices and drivers which are registered against
that bus?

I suspect that if this bus_register doesn't work, you'll see an oops
sooner or later. So it might as well be a BUG_ON here.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/