Re: [PATCH] selinux: fix dentry_open() error check

From: Christoph Hellwig
Date: Mon Nov 27 2006 - 01:36:28 EST


On Mon, Nov 27, 2006 at 03:16:48PM +0900, Akinobu Mita wrote:
> The return value of dentry_open() shoud be checked by IS_ERR().

first great work finding all these calling convetion mismatches.

Do you have some tool to find these?

I wonder whether we should have some form of sparse annotation to
tell that a function returns these kinds of errors and we either
need to check IS_ERR or returned it again a caller with the same attribute.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/