Re: [PATCH] MPT: make all Fusion MPT sub-choices singly selectable

From: Robert P. J. Day
Date: Sat Nov 25 2006 - 15:57:35 EST


On Sat, 25 Nov 2006, Randy Dunlap wrote:

... snip ...

> Here's another option. What do you think of it?

...

> --- linux-2.6.19-rc6-git8.orig/drivers/message/fusion/Kconfig
> +++ linux-2.6.19-rc6-git8/drivers/message/fusion/Kconfig
> @@ -1,14 +1,12 @@
>
> -menu "Fusion MPT device support"
> +menuconfig FUSION
> + bool "Fusion MPT device support"
>
> -config FUSION
> - bool
> - default n
> +if FUSION

... more snip ...

i suspect you already noticed that that's what i proposed in my
followup posting. :-) my first suggestion explicitly didn't mess
with the "Device Drivers" menu, only the underlying MPT submenu.

my second posting went that extra step and added selection boxes to
the Device Drivers menu entries themselves, although your solution is
nicer than mine, surrounding the MPT entries with a single "if FUSION"
rather than my adding a dependency to every selection.

i'm willing to come up with some patches that match your suggestion,
but what do others think of changing the fundamental layout of the
Device Drivers menu (and perhaps other menus) to that extent by adding
that extra selector?

rday
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/