[PATCH] jfs: incorrect use of "&&" instead of "&"

From: Willy Tarreau
Date: Sat Nov 25 2006 - 15:57:26 EST


in jfs_txnmgr, the use of "tblk->flag && COMMIT_DELETE" in a
if() condition is obviously wrong. This bug has already been
fixed in 2.6.

Signed-off-by: Willy Tarreau <w@xxxxxx>
---
fs/jfs/jfs_txnmgr.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/jfs/jfs_txnmgr.c b/fs/jfs/jfs_txnmgr.c
index 62e6493..4e6a280 100644
--- a/fs/jfs/jfs_txnmgr.c
+++ b/fs/jfs/jfs_txnmgr.c
@@ -1175,7 +1175,7 @@ int txCommit(tid_t tid, /* transaction
jfs_ip = JFS_IP(ip);

if (test_and_clear_cflag(COMMIT_Syncdata, ip) &&
- ((tblk->flag && COMMIT_DELETE) == 0))
+ ((tblk->flag & COMMIT_DELETE) == 0))
fsync_inode_data_buffers(ip);

/*
--
1.4.2.4

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/