Re: [PATCH] Fix sys_move_pages when a NULL node list is passed.

[KAMEZAWA Hiroyuki]

On Tue, 7 Nov 2006 18:01:11 -0800 (PST)
Christoph Lameter <clameter@xxxxxxx> wrote:

> On Wed, 8 Nov 2006, KAMEZAWA Hiroyuki wrote:
> 
> > >  	pm[nr_pages].node = MAX_NUMNODES;
> > 
> > I think node0 is always online...but this should be
> > 
> > pm[i].node = first_online_node; // /* any online node */
> 
> No it is a marker. The use of any node that is online could lead to a 
> false determination of the endpoint of the list.
> 
Ah.. I'm mentioning to this.
==
+			pm[i].node = 0;	/* anything to not match MAX_NUMNODES */
==
Sorry for my bad cut & paste.

It seems that this 0 will be passed to alloc_pages_node().
alloc_pages_node() doesn't check whether a node is online or not before using 
NODE_DATA().

-Kame

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/