Re: [PATCH update5] drivers: add LCD support

From: Andrew Morton
Date: Tue Oct 31 2006 - 18:55:19 EST


On Wed, 1 Nov 2006 00:37:48 +0000
Miguel Ojeda Sandonis <maxextreme@xxxxxxxxx> wrote:

> Andrew, here it is the fifth update for the drivers-add-lcd-support.

It does queue_delayed_work(), but forgot to do cancel_delayed_work(). If
the timer is still pending after module unload, deadly things will happen.

There's a lot of "if(" in there. Usual kernel style is "if (".

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/