Re: [PATCH 1/1] fat: improve sync performance by grouping writes revised

From: Holden Karau
Date: Tue Oct 31 2006 - 13:47:39 EST


The performance increase is pretty small. Using an old external dirve
I had lying around I got:
diff -y stock/10k modified/10k
10240+0 records in | 1024+0
records in
10240+0 records out | 1024+0
records out
5242880 bytes transferred in 18.280922 seconds (286795 bytes/ | 524288
bytes transferred in 1.824985 seconds (287283 bytes/se
diff -y stock/1k modified/1k
1024+0 records in 1024+0
records in
1024+0 records out 1024+0
records out
524288 bytes transferred in 1.777250 seconds (295000 bytes/se | 524288
bytes transferred in 1.764748 seconds (297089 bytes/se

The usual disclaimer of any benchmarking applies, YMMV.

Cheers,

Holden :-)

On 10/31/06, OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx> wrote:
Holden Karau <holdenk@xxxxxxxxxxx> writes:

> From: Holden Karau <holden@xxxxxxxxxxxxx> http://www.holdenkarau.com
> This is an attempt at improving fat_mirror_bhs in sync mode [namely it
> writes all of the data for a backup block, and then blocks untill
> finished]. The old behavior would write & block in smaller chunks, so
> this should be slightly faster. It also removes the fix me requesting
> that it be fixed to behave this way :-)

Please post the result of performance test. If it's fairly big, we
would be able to use async for mirror FAT. Instead, for hotplug device
we can provide the another option.
--
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>



--
Cell: 613-276-1645
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/