Re: [PATCH] xacct_add_tsk: fix pure theoretical ->mm use-after-free

[Jay Lan]

Oleg Nesterov wrote:
> On 10/30, Jay Lan wrote:
>> Oleg Nesterov wrote:
>>> Paranoid fix. The task can free its ->mm after the 'if (p->mm)' check.
>> Why this change is necessary? This routine is indirectly invoked by
>> taskstats_exit_send() routine called inside do_exit():
> 
> Not only, please note
> 
> 	taskstats_user_cmd(TASKSTATS_CMD_ATTR_PID)->fill_pid()->xacct_add_tsk()
> 
> path. This tsk is not 'current', it was found by find_task_by_pid(), and
> it may exit at any time.

OK. Thanks!

Acked-by: Jay Lan <jlan@xxxxxxx>

> 
> Oleg.
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/