Re: [PATCH -mm] replacement for broken kbuild-dont-put-temp-files-in-the-source-tree.patch

From: Horst Schirmeier
Date: Mon Oct 30 2006 - 19:28:30 EST


On Mon, 30 Oct 2006, Oleg Verych wrote:
> +# Immortal null for mortals and roots
> +define null
> + $(shell \
> + if test -L null; \
> + then echo null; \
> + else rm -f null; ln -s /dev/null null; \
> + fi)
> +endef

Another remark: the 'else' branch should echo null, too.

# Immortal null for mortals and roots
define null
$(shell \
if test ! -L null; \
then rm -f null; ln -s /dev/null null; \
fi; \
echo null)
endef

My patch proposal (the $(M) one) has the same bug.

Kind regards,
Horst

--
PGP-Key 0xD40E0E7A
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/