Re: [PATCH 2/7] severing fs.h, radix-tree.h -> sched.h

[Roland Dreier]

Trivial comment:

 >  /*
 > + * Superblock locking.  We really ought to get rid of these two.
 > + */
 > +void lock_super(struct super_block * sb)
 > +{
 > +	get_fs_excl();
 > +	mutex_lock(&sb->s_lock);
 > +}
 > +
 > +void unlock_super(struct super_block * sb)
 > +{
 > +	put_fs_excl();
 > +	mutex_unlock(&sb->s_lock);
 > +}
 > +
 > +EXPORT_SYMBOL(lock_super);
 > +EXPORT_SYMBOL(unlock_super);

isn't the current fashion to do this like:

void lock_super(struct super_block * sb)
{
	get_fs_excl();
	mutex_lock(&sb->s_lock);
}
EXPORT_SYMBOL(lock_super);

void unlock_super(struct super_block * sb)
{
	put_fs_excl();
	mutex_unlock(&sb->s_lock);
}
EXPORT_SYMBOL(unlock_super);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/