Re: [PATCH] cm4000_cs: fix return value check
From: Harald Welte
Date: Thu Oct 26 2006 - 06:25:49 EST
On Wed, Oct 25, 2006 at 10:40:04PM -0400, Dominik Brodowski wrote:
> On Tue, Oct 17, 2006 at 03:25:59PM +0900, Akinobu Mita wrote:
> > The return value of class_create() need to be checked with IS_ERR().
> > And register_chrdev() returns errno on failure.
> > This patch includes these fixes for cm4000_cs and cm4040_cs.
> >
> > Cc: Harald Welte <laforge@xxxxxxxxxxxx>
> > Signed-off-by: Akinbou Mita <akinobu.mita@xxxxxxxxx>
>
> Temporarily applied to pcmica-2.6.git, thanks. Harald, do you ACK?
yes, sorry. I've been too busy and the mail slipped through...
The patch is obviously fine. Thanks!
Signed-off-by: Harald Welte <laforge@xxxxxxxxxxxx>
--
- Harald Welte <laforge@xxxxxxxxxxxx> http://gnumonks.org/
============================================================================
We all know Linux is great...it does infinite loops in 5 seconds. -- Linus
Attachment:
pgp00000.pgp
Description: PGP signature