Re: [ltp] Re: [PATCH v2] Re: Battery class driver.

From: FeRD
Date: Thu Oct 26 2006 - 05:55:35 EST


Shem Multinymous wrote:
Hi,

On 10/25/06, David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote:
If you can summarise the bits I've missed in the meantime that would be
wonderfully useful

OK. Looking at the current git snapshot:
[...]
Why the reversed order, for example, in design_charge vs. charge_last?
Following hwmon style, I think it should be
s/design_charge/charge_design/
s/manufacture_date/date_manufactured/
s/first_use/date_first_used/
s/design_voltage/voltage_design/

s/charge_last/charge_last_full/ seems less ambiguous.

s/^charge$/charge_left/ follows SBS and seems better.
Can I propose a further

s/left/remaining/

...flung at the above? Best to avoid "left" as anything but the opposite of "right", if disambiguation is the goal.

-FeRD

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/