Re: [PATCH] Fix generic WARN_ON message

[Pavel Machek]

Hi!

> * Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
> 
> > A warning is a warning, not a BUG.
> 
> > -		printk("BUG: warning at %s:%d/%s()\n", __FILE__,	\
> > +		printk("WARNING at %s:%d %s()\n", __FILE__,	\
> 
> i'm not really happy about this change.
> 
> Firstly, most WARN_ON()s are /bugs/, not warnings ... If it's a real 
> warning, a KERN_INFO printk should be done.
> 
> Secondly, the reason i changed it to the 'BUG: ...' format is that i 
> tried to make it easier for automated tools (and for users) to figure 
> out that a kernel bug happened.

Well... but the message is really bad. It leads to users telling us "I
hit BUG in kernel"...
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/