Re: [PATCH] Use extents for recording what swap is allocated.

From: Christoph Hellwig
Date: Tue Oct 24 2006 - 16:43:00 EST


On Mon, Oct 23, 2006 at 02:14:17PM +1000, Nigel Cunningham wrote:
> Switch from bitmaps to using extents to record what swap is allocated;
> they make more efficient use of memory, particularly where the allocated
> storage is small and the swap space is large.
>
> This is also part of the ground work for implementing support for
> supporting multiple swap devices.

In addition to the very useful comments from Rafael there's some observations
of my own:

- there's an awful lot of opencoded list manipulation, any chance you
could use list.h instead?
- what unit are the extent values in? The usage of unsigned long rings
warning bells for me, shouldn't this be something like pgoff_t or
sector_t depending on what you describe with it?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/