Re: [PATCH] appletalk: prevent unregister_sysctl_table() with a NULL argument

[Alexey Dobriyan]

On Tue, Oct 24, 2006 at 05:53:57PM +0900, Akinobu Mita wrote:
> If register_sysctl_table() fails during module initalization,
> NULL pointer dereference will happen in the module cleanup.

> --- work-fault-inject.orig/net/appletalk/sysctl_net_atalk.c
> +++ work-fault-inject/net/appletalk/sysctl_net_atalk.c
> @@ -78,5 +78,6 @@ void atalk_register_sysctl(void)
>
>  void atalk_unregister_sysctl(void)
>  {
> -	unregister_sysctl_table(atalk_table_header);
> +	if (atalk_table_header)
> +		unregister_sysctl_table(atalk_table_header);

Make sure that module won't load if sysctl table can't be registered,
instead.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/