Re: [PATCH] do not compile AMD Geode's hwcrypto driver as a module per default

From: Borislav Petkov
Date: Tue Oct 24 2006 - 01:49:49 EST


On Mon, Oct 23, 2006 at 10:21:14PM +0200, Michael Buesch wrote:
> On Monday 23 October 2006 13:25, Alan Cox wrote:
> > Ar Sad, 2006-10-21 am 10:17 +0200, ysgrifennodd Borislav Petkov:
> > > This one should be probably made dependent on some #define saying that the cpu
> > > is an AMD and has the LX Geode crypto hardware built in. Turn it off for now.
> >
> > That makes no real sense. Most kernel selections are "run on lots of
> > processor types", we thus want as much as possible modular, built and
> > available.
> >
> > The existing defaults seem quite sane.
>
> I can only second that.
> Building it as a module does not hurt, except few k disk space.
> But that does not really hurt, given today's disk sizes. ;)
> And if you have a small disk, you can still disable it.

I get that, but my concern was primarily with the increasing build durations of
the kernel whenever new modules get added in and people want them to be built on
as many systems as possible so as to catch as more bugs as possible. But since
we _want_ that, diskspace is not an issue.

However, it still does not help that much since I can only test-build the module
but not test-use it for I don't have the hardware.

--
Regards/Gruß,
Boris.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/