Re: [PATCH] [PATCH] Rename pdc_init

From: Matthew Wilcox
Date: Fri Oct 06 2006 - 13:03:50 EST


On Fri, Oct 06, 2006 at 12:42:18PM -0400, Jeff Garzik wrote:
> I don't mind the patch (you should have CC'd me and linux-ide though),

We really need to figure out how to communicate that better. I just
sent it to the maintainer (as listed in MODULE_AUTHOR). Do we need a
MODULE_CHANGES_CC macro too?

> but where is parisc's pdc_init actually used, and why is it global?

Hmm. Embarrassing. Seems it's a stale prototype; I'll delete it.

OTOH, there is a pdc_init in avr32, and it's prudent to not have two
functions of the same name, so that you know which one is appearing in a
backtrace. So it might be a good idea to apply this patch anyway.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/