Re: [PATCH 3/4] 2.6.18-mm2 pktcdvd: restructure code

From: Peter Osterlund
Date: Mon Oct 02 2006 - 18:01:17 EST


"Thomas Maier" <balagi@xxxxxxxxxxx> writes:

> this patch 3/4 for pktcdvd against Linux 2.6.18 (stable)
> or 2.6.18-mm2 restructures the code for better readability
> and prepares it for the sysfs interface code following in patch 4/4.

This is still kind of hard to review. It would be much better if it
was split in two parts, where the first part only moved existing
functions around, and the second part added other neat things, such as
the pkt_find_dev() and pkt_find_dev_bdev() functions.

--
Peter Osterlund - petero2@xxxxxxxxx
http://web.telia.com/~u89404340
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/