Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather thanpassing to IRQ handlers

[Alan Stern]

On Mon, 2 Oct 2006, David Brownell wrote:

> > >  (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking.  It does
> > >      something different depending on whether it's been supplied with a regs
> > >      pointer or not.
> 
> gaak!  where did that come from?  I'll be surprised if removing
> that causes any problem at all.

Here's the statement in question:

	if (likely (regs && HC_IS_RUNNING(ohci_to_hcd(ohci)->state))) {
		...

Notice another questionable use of hcd->state.  I don't know what the 
correct change here is, but I suspect David H's isn't optimal.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/