Re: [linux-usb-devel] [PATCH] driver for mcs7830 (aka DeLOCK) USBethernet adapter

From: David Hollis
Date: Thu Sep 07 2006 - 15:54:37 EST


On Sun, 2006-09-03 at 23:40 -0700, David Brownell wrote:

>
> > Going through the ethtool operations, I think that it should be
> > possible to implement a few of them, including ETHTOOL_GREGS,
> > ETHTOOL_GEEPROM, ETHTOOL_SEEPROM, ETHTOOL_NWAY_RST and ETHTOOL_GPERMADDR.
> > Do you think these should be done?
>
> I've not got much use for those, but maybe the netdev folk would
> care. That's probably not enough to hold up any merge.

Definitely not showstoppers, but nice touches just to ensure that all
things work as expected. The ones of most importance as I see it are
the get/set_settings ones, which you can just pass-thru to the
mii_ethtool_Xset() calls and get_drvinfo(). All others are somewhat
optional and do vary from device to device.

--
David Hollis <dhollis@xxxxxxxxxxxxxx>

Attachment: signature.asc
Description: This is a digitally signed message part