Re: 2.6.18-rc5-mm1: strange /proc/interrupts contents on HPC nx6325

[Ingo Molnar]

* Andrew Morton <akpm@xxxxxxxx> wrote:

> This is due to a gruesome hack (IMO) in the genirq code 
> (handle_irq_name()) which magically "knows" about the various types of 
> IRQ handler, but doesn't know about the MSI ones.  It should be 
> converted to a field in irq_desc, or a callback or something.

a field in irq_desc[] was frowned upon during initial genirq review, due 
to size reasons, so i removed it and replaced it with the hack.

> I already had a whine about this then forgot about it, but it seems that
> code can't be changed by whining at it ;)

;)

i think we could add a 'register handler name' API (or extend 
set_irq_handler() API), to pass in the name of handlers, and store it in 
a small array (instead of embedding it in irq_desc)? handle_irq_name() 
is not performance-critical.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/