Re: [PATCH] fail kernel compilation in case of unresolved symbols (v2)

From: Olaf Hering
Date: Thu Sep 07 2006 - 07:04:04 EST


On Thu, Sep 07, Kirill Korotaev wrote:

> At stage 2 modpost utility is used to check modules.
> In case of unresolved symbols modpost only prints warning.
>
> IMHO it is a good idea to fail compilation process in case of
> unresolved symbols (at least in modules coming with kernel),
> since usually such errors are left unnoticed, but kernel
> modules are broken.

It clearly depends on the context. An unimportant dvb module may have
unresolved symbols, but the drivers for your root filesystem should
rather not have unresolved symbols.

Better leave the current default, your patch seems to turn an unresolved
symbol with "unknown importance" into a hard error.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/