Re: lockdep oddity
From: Ingo Molnar
Date: Wed Sep 06 2006 - 04:45:49 EST
* Hua Zhong <hzhong@xxxxxxxxx> wrote:
> We are just trading accuracy for speed here.
no, we are trading _both_ accuracy and speed here! a global 'likeliness'
pointer for commonly executed codepaths is causing global cacheline
ping-pongs - which is as bad as it gets.
the right approach, which incidentally would also be perfectly accurate,
is to store an alloc_percpu()-ed pointer at the call site, not the
counter itself.
the current code needs more work before it can go upstream i think.
Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/