Re: [PATCH 07/16] GFS2: Directory handling

[Ingo Molnar]

* Andreas Schwab <schwab@xxxxxxx> wrote:

> >> > >+	if (dent->de_inum.no_addr != 0 &&
> >> > >+	    be32_to_cpu(dent->de_hash) == name->hash &&
> >> > >+	    be16_to_cpu(dent->de_name_len) == name->len &&
> >> > >+	    memcmp((char *)(dent+1), name->name, name->len) == 0)
> >> > 
> >> > Nocast.
> >> > 
> >> ok
> >
> > actually, sizeof(*dent) != 1, so how can a non-casted memcmp be correct 
> > here?
> 
> How can the cast change anything?

yeah - i for a minute thought that the '+' is outside the cast - but it 
is inside.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/