Re: [PATCH 0/7] Permit filesystem local caching and NFS superblock sharing [try #13]

[David Howells]

Ian Kent <raven@xxxxxxxxxx> wrote:

> > As long as you don't rely on stat...mkdir working.  That can go wrong if the
> > dentry gets booted from the dcache by memory pressure in the "...".
> 
> I'm not clear on your point here.

I was wondering if you were going to rely on stat() forcing the dentry to be
correctly initialised before you did mkdir(), but it seems not.

> If I stat a path and it exists then all is good and I'm done.
> If I stat a path and I get something other than ENOENT then all is bad
> and I return fail.
> Otherwise I can just attempt to create the directory and fail if all is
> bad with that.

Okay, I suppose.  But that still doesn't seem to deal with the case of creating
a directory on the client that then overlays a symlink on the server that you
can't yet access.

You may also get ENOENT because you stat a symlink, though you'll get EEXIST
from mkdir, even if there's nothing at the far end.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/