Re: [PATCH] proc: readdir race fix.
From: KAMEZAWA Hiroyuki
Date: Mon Sep 04 2006 - 22:35:28 EST
On Tue, 5 Sep 2006 10:30:10 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:
> Hi,
>
> On Mon, 04 Sep 2006 17:13:10 -0600
> ebiederm@xxxxxxxxxxxx (Eric W. Biederman) wrote:
> > These better semantics are implemented by scanning through the
> > pids in numerical order and by making the file offset a pid
> > plus a fixed offset.
> I think this is very sane/solid approach.
> Maybe this is the way to go. I'll test and ack later, thank you.
>
Just a memo:
One interesting aspect of this patch is..
- default result of ps with current(old) kernel is naturally sorted by starttime.
then, ps command itself comes at the bottom of the result, as the newest process.
- default result of ps with this patch is sorted by pid, regardless of starttime.
==
kamezawa 3770 0.0 0.0 5156 996 tty1 S+ 11:17 0:00 /bin/bash ./testp
kawamura 3989 0.0 0.0 2168 832 pts/3 S+ 11:32 0:00 sh -c (cd /usr/sh
kawamura 3990 0.0 0.0 2168 408 pts/3 S+ 11:32 0:00 sh -c (cd /usr/sh
kawamura 4002 0.0 0.0 1924 680 pts/3 S+ 11:32 0:00 /usr/bin/less -iR
root 10772 0.0 0.0 6912 2188 ? Ss 11:31 0:00 sshd: kawamura [p
kamezawa 12341 0.6 0.0 5336 1476 tty2 Ss 11:17 0:06 -bash
kamezawa 15308 0.0 0.0 4788 544 tty1 S+ 11:32 0:00 sleep 1
kamezawa 15315 0.0 0.0 2380 756 pts/0 R+ 11:32 0:00 ps aux
kamezawa 17322 0.0 0.0 5332 1472 tty3 Ss+ 11:18 0:00 -bash
root 22194 0.0 0.0 1760 744 ? Ss 11:20 0:00 in.telnetd: awork
root 22198 0.0 0.0 2992 1476 ? Ss 11:20 0:00 login -- kamezawa
kawamura 24526 0.0 0.0 6912 1544 ? S 11:31 0:00 sshd: kawamura@pt
kawamura 24529 0.0 0.0 5336 1456 pts/3 Ss 11:31 0:00 -bash
satoshi 26239 2.2 0.3 40292 13696 ? Sl 11:30 0:02 /usr/bin/gnome-te
==
But 'ps --sort start_time' is available.
-Kame
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/