Re: [PATCH 18/22][RFC] Unionfs: Superblock operations

[Andreas Schwab]

Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx> writes:

>>+/* final actions when unmounting a file system */
>>+static void unionfs_put_super(struct super_block *sb)
>>+{
>>+	int bindex, bstart, bend;
>>+	struct unionfs_sb_info *spd;
>>+
>>+	if ((spd = stopd(sb))) {
>
> Sugg.:
>
> if((spd = stopd(sb)) == NULL)
> 	return;

Better:

  spd = stopd(sb);
  if (!spd)
          return;

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@xxxxxxx
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

-- 
VGER BF report: H 0
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/