Re: [PATCH 16/22][RFC] Unionfs: Handling of stale inodes

[Jan Engelhardt]

>+static void *stale_follow_link(struct dentry *dent, struct nameidata *nd)
>+{
>+	int err = vfs_follow_link(nd, ERR_PTR(-ESTALE));
>+	return ERR_PTR(err);
>+}

{
	return ERR_PTR(vfs_follow_link(nd, ERR_PTR(-ESTALE)));
}?

>+#define ESTALE_ERROR ((void *) (return_ESTALE))

#define ESTALE_ERROR ((void *)return_ESTALE)

That really looks BSDish, violating the number of args ;-)


Jan Engelhardt
-- 

-- 
VGER BF report: H 0
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/