Re: [PATCH 08/22][RFC] Unionfs: Directory manipulation helper functions

[Jeremy Fitzhardinge]

Jan Engelhardt wrote:
> > +	if (0 <= bopaque && bopaque < bend)
> >     
>
> Turn it. Constant values are usually wanted on the right side.
>
> 	bopaque >= 0

Not in this case.  The test in its current form clearly shows that 
bopaque needs to be within a range.


   J

--
VGER BF report: H 0
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/