Re: [PATCH 03/16] GFS2: bmap and inode functions

From: Ingo Molnar
Date: Sat Sep 02 2006 - 12:30:57 EST



* Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx> wrote:

> >> How about inverting the if() to:
> >>
> >> if(ip == NULL)
> >> return;
> >> if(test_bit(GLF_DIRTY, &gl->gl_flags))
> >> gfs_inode_attr_in(ip);
> >> gfs2_meta_cache_flush(ip);
> >
> >btw., it should be "if (", not "if(".
>
> There is no such rule in CodingStyle.

still it's part of the proper coding style :)

Ingo

--
VGER BF report: H 0
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/