Re: [PATCH 10/18] 2.6.17.9 perfmon2 patch for review: PMU contextswitch support

[Andrew Morton]

On Wed, 23 Aug 2006 01:06:01 -0700
Stephane Eranian <eranian@xxxxxxxxxxxxxxxxx> wrote:

> +#define PFM_LAST_CPU(ctx, act) \
> +	((ctx)->last_cpu == smp_processor_id() && (ctx)->last_act == act)

Hiding this in a macro rather invites mistakes.  Has all this code been
thoroughly tested with CONFIG_DEBUG_PREEMPT, to detect use of
smp_processor_id() in preemptible code?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/