Re: [PATCH] block_dev.c mutex_lock_nested() fix

[Andrew Morton]

On Wed, 23 Aug 2006 11:09:35 -0400 (EDT)
Jason Baron <jbaron@xxxxxxxxxx> wrote:

> 
> Hi,
> 
> In the case below we are locking the whole disk not a partition. This 
> change simply brings the code in line with the piece above where when we 
> are the 'first' opener, and we are a partition.
> 
> thanks,
> 
> -Jason
> 
> Signed-off-by: Jason Baron <jbaron@xxxxxxxxxx>
> 
> --- linux-2.6/fs/block_dev.c.bak
> +++ linux-2.6/fs/block_dev.c
> @@ -966,7 +966,7 @@ do_open(struct block_device *bdev, struc
>  				rescan_partitions(bdev->bd_disk, bdev);
>  		} else {
>  			mutex_lock_nested(&bdev->bd_contains->bd_mutex,
> -					  BD_MUTEX_PARTITION);
> +					  BD_MUTEX_WHOLE);
>  			bdev->bd_contains->bd_part_count++;
>  			mutex_unlock(&bdev->bd_contains->bd_mutex);
>  		}

This was allegedly (re-re-re-re-)fixed in 2.6.18-rc4-mm2. 
lockdep-fix-blkdev_open-warning.patch and
lockdep-fix-blkdev_open-warning-fix.patch.

Is this patch needed in that kernel?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/