Re: call panic if nl_table allocation fails

[James Morris]

On Wed, 23 Aug 2006, Akinobu Mita wrote:

> This patch makes crash happen if initialization of nl_table fails
> in initcalls. It is better than getting use after free crash later.

>  	nl_table = kcalloc(MAX_LINKS, sizeof(*nl_table), GFP_KERNEL);

Perhaps it'd be better to declare this as an array rather than allocating 
it at runtime.



- James
-- 
James Morris
<jmorris@xxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/