Re: sym53c8xx PCI card broken in 2.6.18

From: David Miller
Date: Wed Aug 23 2006 - 01:47:33 EST

From: "Eric Brower" <ebrower@xxxxxxxxx>
Date: Tue, 22 Aug 2006 22:35:14 -0700

> Would you consider assigning -1 to lenp (if provided) in
> of_find_property() when no matching device is found?

I think checking for NULL should be the first thing a caller of these
interfaces should do. So from that perspective, I don't think putting
anything in *lenp makes sense. It's value is undefined.

In fact since we'll leave *lenp alone if the property doesn't exist,
you can initialize it to -1 if you want to simplify your checks.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at