Re: sym53c8xx PCI card broken in 2.6.18

From: David Miller
Date: Tue Aug 22 2006 - 23:58:56 EST

From: "Eric Brower" <ebrower@xxxxxxxxx>
Date: Tue, 22 Aug 2006 20:59:14 -0700

> The envctrl OOPS is definately my fault in the blind conversion of the
> driver to the OF interface-- of_find_propery() return values should be
> checked for NULL rather than relying upon a -1 value stored into lenp.
> We can discuss this separately, since you are using an out-of-kernel
> driver.


BTW, it is better to use "of_get_property()" if you are actually
interested in the value since it will return a void pointer to the
property value instead of a "struct property". of_find_property() is
useful if you just want to check for existence or if you want to
modify the property value.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at